Skip to content

fix(ui): resolve Copilot PR reviews for newsletter and loader contrast#5408

Merged
princerajpoot20 merged 2 commits into
asyncapi:website-uifrom
sammy200-ui:website-ui-newsletter-copilot-fixes
May 20, 2026
Merged

fix(ui): resolve Copilot PR reviews for newsletter and loader contrast#5408
princerajpoot20 merged 2 commits into
asyncapi:website-uifrom
sammy200-ui:website-ui-newsletter-copilot-fixes

Conversation

@sammy200-ui
Copy link
Copy Markdown
Contributor

@sammy200-ui sammy200-ui commented May 12, 2026

Issue was that the text was black
Before
Screenshot 2026-05-16 at 9 09 15 PM

after
Screenshot 2026-05-12 at 10 03 52 PM

The loader was not visible
before

Screenshot 2026-05-16 at 9 11 15 PM

after

Screenshot 2026-05-16 at 9 12 05 PM

ref : #5399 (comment)

Summary by CodeRabbit

  • Style
    • Improved dark-mode support for loader text so it now switches colors appropriately between light and dark themes.
    • Updated the TSC community newsletter CTA styling (text centered) and enabled dark-theme styling for the CTA to improve contrast.

Review Change Stack

@netlify
Copy link
Copy Markdown

netlify Bot commented May 12, 2026

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit dcc7013
🔍 Latest deploy log https://app.netlify.com/projects/asyncapi-website/deploys/6a035e90ed102a0008aee7b6
😎 Deploy Preview https://deploy-preview-5408--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: dec312f7-3275-42b3-be55-ee8538a3046f

📥 Commits

Reviewing files that changed from the base of the PR and between c508ecd and dcc7013.

📒 Files selected for processing (2)
  • components/Loader.tsx
  • pages/community/tsc.tsx

📝 Walkthrough

Walkthrough

Loader text now supports Tailwind dark mode (text-black dark:text-white). The TSC community page passes a dark prop to NewsletterSubscribe and changes the CTA text class from text-white to text-center.

Changes

Dark Mode Support

Layer / File(s) Summary
Loader dark mode text styling
components/Loader.tsx
Loader text class updated to text-black dark:text-white so the text color automatically switches with Tailwind dark mode.
TSC page newsletter prop and CTA styling
pages/community/tsc.tsx
NewsletterSubscribe is passed a dark prop and the CTA text class was changed from text-white to text-center.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • derberg
  • princerajpoot20
  • akshatnema
  • sambhavgupta0705
  • anshgoyalevil
  • Mayaleeeee
  • asyncapi-bot-eve

Poem

🐰 I hop through code both day and night,
I swap the dark and make it right,
A tiny class, a prop passed through,
Now text will flip from black to hue,
A cheerful nibble — theme in sight.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main changes: fixing UI contrast issues in the newsletter and loader components.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sammy200-ui
Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 12, 2026

✅ Actions performed

Full review triggered.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses dark-theme visibility issues in UI components, specifically improving contrast for the Newsletter subscription section on the TSC page and ensuring loader text remains readable in dark mode.

Changes:

  • Updated pages/community/tsc.tsx to use the dark prop on NewsletterSubscribe and reformatted inline gradient styles.
  • Updated components/Loader.tsx to apply dark:text-white so loader text remains visible when the site is in dark mode.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
pages/community/tsc.tsx Switches TSC newsletter section to NewsletterSubscribe dark and reformats gradient style objects.
components/Loader.tsx Ensures loader text switches to white under Tailwind dark mode when dark={false}.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pages/community/tsc.tsx
<NewsletterSubscribe
type='TSC Voting'
title='Get notified when TSC is voting'
subtitle="You'll receive an email whenever someone requests the TSC to vote"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

considered

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (c508ecd) to head (dcc7013).
⚠️ Report is 1 commits behind head on website-ui.

Additional details and impacted files
@@             Coverage Diff              @@
##           website-ui     #5408   +/-   ##
============================================
  Coverage      100.00%   100.00%           
============================================
  Files              22        22           
  Lines             830       830           
  Branches          159       159           
============================================
  Hits              830       830           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sammy200-ui sammy200-ui force-pushed the website-ui-newsletter-copilot-fixes branch from 5220f20 to 321ea2a Compare May 12, 2026 16:45
@sammy200-ui sammy200-ui force-pushed the website-ui-newsletter-copilot-fixes branch from 321ea2a to f7240cc Compare May 12, 2026 16:55
@sonarqubecloud
Copy link
Copy Markdown

@sammy200-ui sammy200-ui requested a review from Copilot May 12, 2026 17:11
@sammy200-ui
Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 12, 2026

✅ Actions performed

Full review triggered.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comment thread pages/community/tsc.tsx
title='Get notified when TSC is voting'
subtitle="You'll receive an email whenever someone requests the TSC to vote"
className='text-white'
className='text-center'
Comment thread components/Loader.tsx
<div className={twMerge(`w-fit flex gap-4 m-auto items-center ${pulsating ? 'animate-pulse ' : ''} ${className}`)}>
{loaderIcon}
<div className={`my-2 ${dark ? 'text-white' : 'text-black'}`}>{loaderText}</div>
<div className={`my-2 ${dark ? 'text-white' : 'text-black dark:text-white'}`}>{loaderText}</div>
@sammy200-ui
Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 16, 2026

✅ Actions performed

Full review triggered.

@sammy200-ui
Copy link
Copy Markdown
Contributor Author

@princerajpoot20 should be ready for review

@princerajpoot20 princerajpoot20 merged commit 0c0764e into asyncapi:website-ui May 20, 2026
38 of 39 checks passed
@github-project-automation github-project-automation Bot moved this from To Be Triaged to Done in Website - Kanban May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants